Skip to content

[3.14] gh-134837: Correct and improve base85 documentation for base64 module (GH-145843)#149743

Open
serhiy-storchaka wants to merge 1 commit into
python:3.14from
serhiy-storchaka:backport-e667d62-3.14
Open

[3.14] gh-134837: Correct and improve base85 documentation for base64 module (GH-145843)#149743
serhiy-storchaka wants to merge 1 commit into
python:3.14from
serhiy-storchaka:backport-e667d62-3.14

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented May 12, 2026

…base64 and binascii modules (pythonGH-145843)

(cherry picked from commit e667d62)

Co-authored-by: David Huggins-Daines <dhd@ecolingui.ca>
@serhiy-storchaka
Copy link
Copy Markdown
Member Author

@dhdaines, please look if anything more is needed for this backport.

There are no changes in the binascii module, because it only supports Base85 since 3.15. There are less other parameters, most important -- there is no pad parameter for Z85 encoder.

@dhdaines
Copy link
Copy Markdown
Contributor

Great! I will take a look a bit later. Given that there's no pad parameter and the default is False, the behaviour of the Z85 encoder is non-conforming (ZeroMQ specifies that Z85 data should always be padded to a multiple of 4 bytes input / 5 bytes output), so that may be worth noting in the documentation.

@dhdaines
Copy link
Copy Markdown
Contributor

A few minor changes to suggest, but nothing really crucial: serhiy-storchaka#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants